Advanced search queries #2934

juliusknorr · 2021-04-01T09:46:55Z

Based on #2933

Implement advanced search queries (see detailed description below)
Proper pagination in unified search providers
Implement card comment search in unified search
Add global search result UI to deck
Extend card details route in frontend to navigate to a specific sidebar tab directly
Some refactoring on the integration tests in order to writing the search tests and further ones more straight forward

Global search in Deck

A dedicated inline search input was added in order to properly indicate that a search filtering is still active even if the unified search is closed:

Search queries

The search will only return results that match all of the search tokens.

Example query: project tag:ToDo assigned:alice assigned:bob

Will return all cards where the card title or description contains project AND the tag ToDo is set AND the user alice is assigned AND the user bob is assigned

Filter	Operators	Query	Tests
title	`:`	text token used for a case-insentitive search on the cards title	x
description	`:`	text token used for a case-insentitive search on the cards description	x
list	`:`	text token used for a case-insentitive search on the cards list name	x
tag	`:`	text token used for a case-insentitive search on the assigned tags	x
date	`:`	'overdue', 'today', 'week', 'month', 'none'	x
	`>` `<` `>=` `<=`	Compare the card due date to the passed date (see supported date formats) Card due dates are always considered UTC for comparison	x
assigned	`:`	id or displayname of a user or group for a search on the assigned users or groups	x

Other text tokens will be used to perform a case-insensitive search on the card title and description

Quotes can be used to pass a query with spaces, e.g. title:"My card"

lib/Controller/SearchController.php

nickvergessen · 2021-04-12T12:42:08Z

lib/Search/DeckProvider.php

-		return SearchResult::complete(
+		if (count($cardResults) < $query->getLimit()) {
+			return SearchResult::complete(
+				'Deck',


I guess that is a different discussion, as we currently never translate the app name for deck.

nickvergessen · 2021-04-12T12:42:15Z

lib/Search/DeckProvider.php

+			);
+		}
+
+		return SearchResult::paginated(
 			'Deck',


PVince81

partial review

lib/Db/Card.php

lib/Db/CardMapper.php

lib/Search/FilterStringParser.php

lib/Service/SearchService.php

src/components/search/GlobalSearchResults.vue

PVince81 · 2021-04-12T11:04:44Z

src/components/search/Placeholder.vue

+	<div class="card--placeholder">
+		<svg class="card-placeholder__gradient">
+			<defs>
+				<linearGradient id="card-placeholder__gradient">


please check the placeholder from Talk, I had to replace it as it was causing high cpu load due to dynamic SVG gradient not being GPU accelerated: nextcloud/spreed#4554

or raise a ticket to change this later

Will do a follow up ticket for this and the unified search in the server where this was inspired from

Unified search in server Unified search placeholders shouldn't use dynamic svg gradients server#26545

Deck Unified search placeholders shouldn't use dynamic svg gradients #2975

PVince81

second part of review

PVince81 · 2021-04-12T13:09:52Z

src/store/card.js

+						} else if (filter === 'tag') {
+							hasMatch = hasMatch && card.labels.findIndex((label) => label.title.toLowerCase().includes(filterOutQuotes(query).toLowerCase())) !== -1
+						} else if (filter === 'date') {
+							const datediffHour = ((new Date(card.duedate) - new Date()) / 3600 / 1000)


maybe use moment for diffing dates to avoid potential troubles when crossing DST offsets (rare, so probably not cricial)

This is for now using the same logic as the local board filters but I'll split this into a separate ticket for refining both both them.

src/store/card.js

PVince81 · 2021-04-12T13:13:25Z

src/store/card.js

+								return false
+							}
+							const comparator = query[0] + (query[1] === '=' ? '=' : '')
+							const isValidComparator = ['<', '<=', '>', '>='].indexOf(comparator) !== -1


throw error in case of no valid comparator ?

Until now invalid queries would just attempt to perform an equal comparison for whatever is passed after the :. I'd keep that for now and move the handling improvement of that into a ticket so we can discuss where and how to show possible errors especially with the unified search, where we'd need server improvements to return possible hints or errors to the user.

tests/integration/features/search.feature

PVince81

Code looks good now, thanks for the adjustments 👍

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr added this to the 1.4.0 milestone Apr 7, 2021

juliusknorr force-pushed the enh/advanced-search branch from 5b8d838 to 71b081d Compare April 9, 2021 14:23

juliusknorr force-pushed the enh/fts-events branch from d7f52f9 to e42e064 Compare April 12, 2021 06:15

juliusknorr force-pushed the enh/advanced-search branch 6 times, most recently from 1563333 to d8f915e Compare April 12, 2021 06:53

juliusknorr marked this pull request as ready for review April 12, 2021 06:53

juliusknorr force-pushed the enh/advanced-search branch from d8f915e to 45480e2 Compare April 12, 2021 09:43

juliusknorr requested review from nickvergessen, rullzer and ChristophWurst April 12, 2021 09:44

juliusknorr added 3. to review enhancement labels Apr 12, 2021

juliusknorr requested a review from skjnldsv April 12, 2021 09:47

nickvergessen reviewed Apr 12, 2021

View reviewed changes

lib/Controller/SearchController.php Outdated Show resolved Hide resolved

nickvergessen reviewed Apr 12, 2021

View reviewed changes

lib/Search/DeckProvider.php

);

}

return SearchResult::paginated(

'Deck',

Copy link

Member

nickvergessen Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

PVince81 reviewed Apr 12, 2021

View reviewed changes

juliusknorr force-pushed the enh/advanced-search branch 2 times, most recently from 236d061 to 32c30c2 Compare April 13, 2021 08:56

juliusknorr requested review from nickvergessen and PVince81 April 13, 2021 08:56

juliusknorr force-pushed the enh/fts-events branch 2 times, most recently from 4be98da to 174d74c Compare April 13, 2021 09:05

juliusknorr mentioned this pull request Apr 13, 2021

Move full text search to proper events #2933

Merged

juliusknorr force-pushed the enh/advanced-search branch from 32c30c2 to 35816f0 Compare April 13, 2021 09:07

PVince81 approved these changes Apr 13, 2021

View reviewed changes

Base automatically changed from enh/fts-events to master April 13, 2021 12:12

juliusknorr added 10 commits April 13, 2021 14:13

Implement advanced search queries

840c143

Signed-off-by: Julius Härtl <[email protected]>

Add global result frontend

c960d21

Signed-off-by: Julius Härtl <[email protected]>

Integration tests for search

a6c4912

Signed-off-by: Julius Härtl <[email protected]>

Add composer scripts for php tests

73fce1d

Signed-off-by: Julius Härtl <[email protected]>

Add card sidebar tab navigation to router

030cc4e

Signed-off-by: Julius Härtl <[email protected]>

Add inline search input

0f10e1f

Signed-off-by: Julius Härtl <[email protected]>

Attempt to fix psalm false-positive

6b6aef0

Signed-off-by: Julius Härtl <[email protected]>

Fix global search in overview

e77ca19

Signed-off-by: Julius Härtl <[email protected]>

Improve quote handling in search strings

0f3bbe3

Signed-off-by: Julius Härtl <[email protected]>

Add user docs

af309f7

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr force-pushed the enh/advanced-search branch from 35816f0 to af309f7 Compare April 13, 2021 12:15

Do not log if FTS is unavailable

9970ebc

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr mentioned this pull request Apr 13, 2021

Cast datetime columns in sqlite before comparing nextcloud/server#26540

Merged

Workaround sqlite query issues

990659b

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr merged commit c12e07f into master Apr 13, 2021

juliusknorr deleted the enh/advanced-search branch April 13, 2021 15:30

juliusknorr mentioned this pull request May 3, 2021

upcoming cards: 3-dots menu (Card details) not working #2441

Closed

sorbaugh mentioned this pull request Jan 19, 2024

🔍🗨️ Unified Search in individual Talk room nextcloud/server#42914

Closed

2 tasks

This was referenced Oct 1, 2024

Comments search in unified search #2247

Closed

Support pagination in unified search provider #2248

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advanced search queries #2934

Advanced search queries #2934

juliusknorr commented Apr 1, 2021 •

edited

Loading

nickvergessen Apr 12, 2021

juliusknorr Apr 12, 2021

nickvergessen Apr 12, 2021

PVince81 left a comment

PVince81 Apr 12, 2021

juliusknorr Apr 12, 2021

juliusknorr Apr 13, 2021

PVince81 left a comment

PVince81 Apr 12, 2021

juliusknorr Apr 13, 2021

juliusknorr Apr 13, 2021

PVince81 Apr 12, 2021

juliusknorr Apr 13, 2021

juliusknorr Apr 13, 2021

PVince81 left a comment

Advanced search queries #2934

Advanced search queries #2934

Conversation

juliusknorr commented Apr 1, 2021 • edited Loading

Global search in Deck

Search queries

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

juliusknorr commented Apr 1, 2021 •

edited

Loading